Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Update plugin renderer section #5752

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OlenaPostindustria
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 3de14ce
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/675969daba394b000853360b
😎 Deploy Preview https://deploy-preview-5752--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlenaPostindustria OlenaPostindustria marked this pull request as draft December 11, 2024 09:46
@OlenaPostindustria OlenaPostindustria marked this pull request as ready for review December 11, 2024 10:33
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the code examples, but from my perspective this looks good.

@bretg WDYT?

@muuki88 muuki88 added the LGTM label Dec 12, 2024
@bretg
Copy link
Contributor

bretg commented Dec 12, 2024

@OlenaPostindustria - should these changes also be reflected in the Android version of the documentation?

@OlenaPostindustria
Copy link
Contributor Author

@bretg, these changes have been applied solely to the iOS platform for now.

@bretg
Copy link
Contributor

bretg commented Dec 13, 2024

@OlenaPostindustria - is this documentation associated with a specific version of SDK? i.e. it this ready to merge or do we need to wait for the SDK to release?

@OlenaPostindustria
Copy link
Contributor Author

@bretg, these changes are not released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants